Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support keep and drop #13

Merged
merged 4 commits into from
Oct 27, 2023
Merged

Conversation

jfpedroza
Copy link
Contributor

keep and drop options are not currently supported. This adds filtering with those options.

Copy link
Member

@kamilkowalski kamilkowalski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for contributing!

While playing with your tests I noticed that our testing strategy was a bit off - sometimes the event handler was actually crashing silently and we were neither asserting on the logs it produced or whether the reporter stayed attached to the events.

I decided to take the log-based route as a log message should be printed when the handler crashes, and it allows us to verify we're not producing unnecessary logs - at my current company we had issues with telemetry reporters spamming our logs.

@kamilkowalski kamilkowalski merged commit 564775f into surgeventures:main Oct 27, 2023
15 checks passed
@jfpedroza
Copy link
Contributor Author

We've also had issues with telemetry handles failing silently in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants